Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to JDK12 #267

Closed
4 tasks done
GentlemanHal opened this issue Jan 22, 2019 · 3 comments
Closed
4 tasks done

Update to JDK12 #267

GentlemanHal opened this issue Jan 22, 2019 · 3 comments
Assignees
@GentlemanHal
Labels
improvement Changes that improve an existing feature
Milestone
v4.0.0

Comments

@GentlemanHal
Copy link
Member

GentlemanHal commented Jan 22, 2019 •
edited
Loading

Edit I've update this issue to be upgrading everything to JDK12.

  • Docker
  • CI
  • Production
  • Local development

Original issue below

It also seems getting a Alpine based Docker image for JDK11 might not be simple:

docker-library/openjdk#211

We might be able to use adoptopenjdk/openjdk11:alpine-slim

https://hub.docker.com/r/adoptopenjdk/openjdk11/tags
@GentlemanHal GentlemanHal added the improvement Changes that improve an existing feature label Jan 22, 2019
@GentlemanHal GentlemanHal mentioned this issue Jan 22, 2019
Closed
@GentlemanHal GentlemanHal changed the title Use JDK11 in Docker Use JDK12 in Docker May 30, 2019
GentlemanHal added a commit that referenced this issue Jun 24, 2019
@GentlemanHal
[#267] use zulu openjdk 12
cb01159
GentlemanHal added a commit that referenced this issue Jun 24, 2019
@GentlemanHal
[#267] use zulu openjdk 12 on CI
d180a0c
@GentlemanHal GentlemanHal added this to the v4.0.0 milestone Jun 24, 2019
@GentlemanHal GentlemanHal self-assigned this Jun 24, 2019
@GentlemanHal GentlemanHal changed the title Use JDK12 in Docker Update to JDK12 Jul 6, 2019
@GentlemanHal
Copy link
Member Author

Commit for updating production build-canaries/nevergreen-infra@f8221c1

@GentlemanHal
Copy link
Member Author

GentlemanHal commented Jul 6, 2019 •
edited
Loading

Updating the Docker file has over doubled the size from ~90 MB to ~220 MB.

I found a post (about JDK 11 but hopefully still applicable to 12) that might help, https://stackoverflow.com/questions/53669151/java-11-application-as-lightweight-docker-image/53669152#53669152

I'm not sure if we actually care though? Any thoughts @joejag, @cowley05 or @manasik?

@GentlemanHal
Copy link
Member Author

We are currently happy with this even though the image is large. If the image continues to increase or the size becomes a problem we will raise a new issue to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GentlemanHal GentlemanHal

Labels
improvement Changes that improve an existing feature
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
1 participant
@GentlemanHal