Remove index template from backend #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @CohenIdo, please reference to the related PR on |
kfirpeled
previously approved these changes
Jan 27, 2022
kfirpeled
reviewed
Jan 27, 2022
| @@ -5,7 +5,7 @@ | |||
| * 2.0. | |||
| */ | |||
|
|
|||
| export const CSP_KUBEBEAT_INDEX_PATTERN = 'logs-k8s_cis*'; | |||
| export const CSP_KUBEBEAT_INDEX_PATTERN = 'logs-k8s_cis.result*'; | |||
There was a problem hiding this comment.
is this change necessary?
There was a problem hiding this comment.
nope. just thought that is more accurarte. want me to revert it?
ari-aviran
requested changes
Feb 3, 2022
CohenIdo
force-pushed
the
remove_adding_index_template
branch
from
a2c9478 to
c4fd592
Compare
|
@CohenIdo Please rebase this to solve conflicts and we'll merge this in |
CohenIdo
force-pushed
the
remove_adding_index_template
branch
from
c4fd592 to
2cc3e27
Compare
ari-aviran
approved these changes
Feb 22, 2022
orouz
reviewed
Feb 23, 2022
| */ | ||
| import type { MappingTypeMapping } from '@elastic/elasticsearch/lib/api/types'; | ||
|
|
||
| export const mapping: MappingTypeMapping = { |
There was a problem hiding this comment.
FYI the current findings needs this to do search/sort @kfirpeled, i think it will either not work or may throw now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.