fix(rust): include stddef.h in ockam_ffi/include/vault.h #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrinalwadhwa
requested review from
SanjoDeundiak
and removed request for
mrinalwadhwa
SanjoDeundiak
approved these changes
Jul 20, 2021
|
Rebased and merged as #1569 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add
#include <stddef.h>toockam_ffi/include/vault.h.This is a very minor issue I noticed when flipping through files. In order to get
size_t, which is used all over the place in that code, you should importstddef.h. On some platforms,stdint.hwill itself includestddef.h, which means the include probably works on many targets.This isn't guaranteed though, and at least on my machine (on macOS), it doesn't appear to be the case.