Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): only Output listener service address #3204 #3226

Conversation

michealkeines
Copy link
Contributor

@michealkeines michealkeines commented Aug 15, 2022

Current Behavior

Updated the println! message to print only the addr.address()

image

Checks

@mrinalwadhwa
Copy link
Member

@michealkeines thank you for sending this 🥳
The changes here look good. We'll merge after the commit in the CLA PR is signed. Please see my comment here https://github.com/build-trust/ockam-contributors/pull/97

@michealkeines michealkeines force-pushed the issue-3204-output-only-listenerserviceaddress branch from f5ed92f to 3aa33c8 Compare August 15, 2022 18:02
@michealkeines
Copy link
Contributor Author

I have signed my commits this time!

mrinalwadhwa
mrinalwadhwa previously approved these changes Aug 15, 2022
@mrinalwadhwa mrinalwadhwa force-pushed the issue-3204-output-only-listenerserviceaddress branch from 3aa33c8 to 261abaf Compare August 15, 2022 18:18
@mrinalwadhwa mrinalwadhwa self-requested a review August 15, 2022 18:18
@mrinalwadhwa
Copy link
Member

@michealkeines Thank you for an awesome first contribution 🎉 🎊

I rebased, amended the commit message a bit, and then pushed to your branch ... this will merge in a few minutes when all the CI checks have passed.

@mergify mergify bot merged commit 54e771e into build-trust:develop Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output only listener service address in output of ockam secure-channel-listener create...
2 participants