Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix this: Use of unresolved identifier 'BuildasaurKeys' #243

Closed
wants to merge 1 commit into from

Conversation

rcaileff
Copy link

Update GitServerPublic.swift to call BuildasaurxcodeprojKeys instead.

Update GitServerPublic.swift to call BuildasaurxcodeprojKeys instead.
@czechboy0
Copy link
Member

Hi @rcaileff, thanks for creating the PR, but actually this seems to be some issue with CocoaPods keys, where it names the class differently every time.

I'd prefer if we could keep the name and instead maybe fix the Podfile, which is what Keys use to generate the project? I'd appreciate any insight into how Keys work internally, because I've myself struggled with this exact problem.

@rcaileff
Copy link
Author

Hi Honza,

I unfortunately don't know anything about how CocoaPods keys work. I've
never dealt with them before Buildasaur. When you say it names the class
differently every time, what do you mean by "every time?" Every time
what? I used the same compilation fix on two machines before I created the
PR.

-Rachel

On Wed, Feb 24, 2016 at 6:00 PM, Honza Dvorsky notifications@github.com
wrote:

Hi @rcaileff https://github.com/rcaileff, thanks for creating the PR,
but actually this seems to be some issue with CocoaPods keys, where it
names the class differently every time.

I'd prefer if we could keep the name and instead maybe fix the Podfile,
which is what Keys use to generate the project? I'd appreciate any insight
into how Keys work internally, because I've myself struggled with this
exact problem.


Reply to this email directly or view it on GitHub
#243 (comment).

@czechboy0
Copy link
Member

Sorry you're right, it doesn't change every time, just that I've seen
issues where on my machine it's just called BuildasaurKeys and on CI it was
generated as BuildasaurxcprojectKeys or whatever. I can try to look at it
in the next couple of days - until then, does your fork work for you
otherwise?

On Thu, Feb 25, 2016 at 4:57 PM rcaileff notifications@github.com wrote:

Hi Honza,

I unfortunately don't know anything about how CocoaPods keys work. I've
never dealt with them before Buildasaur. When you say it names the class
differently every time, what do you mean by "every time?" Every time
what? I used the same compilation fix on two machines before I created the
PR.

-Rachel

On Wed, Feb 24, 2016 at 6:00 PM, Honza Dvorsky notifications@github.com
wrote:

Hi @rcaileff https://github.com/rcaileff, thanks for creating the PR,
but actually this seems to be some issue with CocoaPods keys, where it
names the class differently every time.

I'd prefer if we could keep the name and instead maybe fix the Podfile,
which is what Keys use to generate the project? I'd appreciate any
insight
into how Keys work internally, because I've myself struggled with this
exact problem.


Reply to this email directly or view it on GitHub
<#243 (comment)
.


Reply to this email directly or view it on GitHub
#243 (comment).

@rcaileff
Copy link
Author

Ah, I see. Thanks for explaining.

I'm trying to find a CI option for Xcode with a GitHub Enterprise instance
(issue #99 for Buildasaur). So far I haven't found one but I'm not yet out
of options to explore. In parallel I've started looking at how hard it
would be for me to implement that feature for Buildasaur. My first
stumbling block was the build failure. Now I'm trying to figure out OAuth
and how Buildasaur interacts with it.

-Rachel

On Thu, Feb 25, 2016 at 11:22 AM, Honza Dvorsky notifications@github.com
wrote:

Sorry you're right, it doesn't change every time, just that I've seen
issues where on my machine it's just called BuildasaurKeys and on CI it was
generated as BuildasaurxcprojectKeys or whatever. I can try to look at it
in the next couple of days - until then, does your fork work for you
otherwise?

On Thu, Feb 25, 2016 at 4:57 PM rcaileff notifications@github.com wrote:

Hi Honza,

I unfortunately don't know anything about how CocoaPods keys work. I've
never dealt with them before Buildasaur. When you say it names the class
differently every time, what do you mean by "every time?" Every time
what? I used the same compilation fix on two machines before I created
the
PR.

-Rachel

On Wed, Feb 24, 2016 at 6:00 PM, Honza Dvorsky <notifications@github.com

wrote:

Hi @rcaileff https://github.com/rcaileff, thanks for creating the
PR,
but actually this seems to be some issue with CocoaPods keys, where it
names the class differently every time.

I'd prefer if we could keep the name and instead maybe fix the Podfile,
which is what Keys use to generate the project? I'd appreciate any
insight
into how Keys work internally, because I've myself struggled with this
exact problem.


Reply to this email directly or view it on GitHub
<
#243 (comment)
.


Reply to this email directly or view it on GitHub
<#243 (comment)
.


Reply to this email directly or view it on GitHub
#243 (comment).

@czechboy0
Copy link
Member

Oh that's cool! Adding GitHub enterprise shouldn't be that hard, OAuth and all that is already implemented in 1.0.0-b2, so work off of that.

@czechboy0
Copy link
Member

@rcaileff Don't mind the build error here, I'm changing some local XCS configs.

@czechboy0
Copy link
Member

Is this still current or did you get things working in #248?

@rcaileff
Copy link
Author

rcaileff commented Mar 2, 2016

I'm still using BuildasaurxcodeprojKeys in my local execution of the code.

On Wed, Mar 2, 2016 at 12:38 PM, Honza Dvorsky notifications@github.com
wrote:

Is this still current or did you get things working in #248
#248?


Reply to this email directly or view it on GitHub
#243 (comment).

@czechboy0 czechboy0 closed this in c62c401 Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants