New App Icon and small fixes. #74
Conversation
Update to Head.
New App Icon for Buildasaur, also the menu bar icon is rendering as template by default, so there is no need to do it in code - it’s cleaner. Add “Quit Buildasaur” action to menu.
|
Result of integration 1 |
|
I've also noticed, there is an unused method in So I assume it can be deleted. |
|
Very cool icon 👏 I like it. Just a thought - on iOS, you can simply add a single .pdf-file and Xcode will render all the required resolutions of the resource when compiling. I assumed it was like this for OS X as well, but I may be wrong? |
| @@ -19,13 +19,12 @@ class MenuItemManager : NSObject, NSMenuDelegate { | |||
|
|
|||
| let statusItem = statusBar.statusItemWithLength(32) | |||
| statusItem.title = "" | |||
| let image = NSImage(named: "icon") | |||
| image?.setTemplate(true) | |||
There was a problem hiding this comment.
This was added because of issues with compatibility with both light and dark menu bar modes. Did you test that it looks good on both even when you disable templating?
There was a problem hiding this comment.
Yes I set it for icon image as default, so you don't have to set anything in code manually...
There was a problem hiding this comment.
Right, of course, you explained it to me before and I just forgot. All good.
|
@accatyyc Hmm I've actually never tried it, but thanks for tip, I'll look at it... :) |
|
Result of integration 2 |
|
I've updated Builda to be slightly more adorable by rounding his eyes and making smile on his face, but I cannot do another pull request before you process this one.
|
|
Just push more commits into this branch, it will update the pull request. |
|
Ok, in that case, it should be okay. :) |
New App Icon and small fixes.
Hi,
I've made new App Icon, very special just for Buildasaur, because he deserves one, I hope it'll look cool... It's just fast concept, I may slightly change background color or size in the future.
I've also changed rendering mode for menu item, now it's set as template by default, so no extra work in code is needed.
And at the last, I've added "Quit Buildasar" action to menu.
Preview of App Icon
Menu bar icon:
Small App icon:
App icon in Dock:
