-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ᴡᴀᴛᴄʜ #34
ᴡᴀᴛᴄʜ #34
Conversation
@@ -197,6 +239,7 @@ | |||
children = ( | |||
3A7B48BC1B2A5AC40077ABEA /* XcodeServerSDK */, | |||
3A7B48C91B2A5AC40077ABEA /* XcodeServerSDKTests */, | |||
11376BD11B3A2F910005A681 /* XcodeServerSDK - ᴡᴀᴛᴄʜ */, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this new folder reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This folder holds the public header for the ᴡᴀᴛᴄʜ
framework (its different than the other ones; unless we provide target conditionals
Also, please add some support section to the readme so that we can properly declare the support of all platforms (iOS/OS X/watchOS)! |
#32 doesn't stop the project from being buildable; I even provided a personal project where I'm using Regarding the |
Can you merge your |
@czechboy0 done; just rebased from remote Regarding the name; its just unicode; don't think it will choke at any point unless decides to regress and stop supporting them; i'll make the change if needed though |
Ok, can you just do a final check that if you try to run all three platform's schemes one by one and test them, you get the same results? (Number of tests, all succeeding). Then it'll be ready for a merge. |
All test match on both infrastructures (ᴡᴀᴛᴄʜ doesn't support tests yet). Actually PS. I added the |
@esttorhe Sounds good, feel free to add a |
My comment wasn't aim as an attack but rather to show that I wasn't trying to steal the idea 🙇 I'm about to commit the change to I'll create the |
Better reflect what they are.
Haha I know it wasn't. Sounds good, let's start doing that. Maybe also draft a |
Maybe also add minimum deployment targets for each platform? Those can be found in our |
Hopefully 080d47e is the one 😂 |
Let me know when you add the contributing list so that I can merge it 😉 |
Feel free to merge now if you are ok with the I was planning on taking the time to go over all the closed |
Yeah, this one might be good inspiration. |
They have a |
That looks promising. Always liked the CP change log as well. Perhaps explore using this https://github.com/skywinder/github-changelog-generator + the What do you think? |
This tool is pretty awesome. I'd love to not have to ask people to add manual steps when sending PRs. Let's start using this and see how it goes. I'll commit the first changelog after we merge this. |
Fix #33
Adds support for ᴡᴀᴛᴄʜ framework.
Dependencies
This
PR
depends on #32 (because its using the «new»throws
/guard
inits on theXcodeServerConfig
class