Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add explanation on what the bb_runner container situation is about #124

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

lucasmeijer
Copy link
Contributor

Add more information about why there are two bb_runner container images, and when and how to use them.

Copy link
Member

@EdSchouten EdSchouten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you please wrap sentences at <80 columns for consistency with the rest of the document?

Copy link
Contributor

@moroten moroten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Just a few nit picks.

Co-authored-by: Fredrik Medley <moroten@users.noreply.github.com>
@EdSchouten EdSchouten merged commit 9a1e01f into buildbarn:master Feb 2, 2024
@stagnation
Copy link

Great thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants