Tidy up bazel_remote_apis changes #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
EdSchouten
commented
Sep 18, 2024
EdSchouten
commented
- We no longer need to patch up Gazelle to resolve googleapis properly.
- bazel_remote_apis now uses the gRPC v2 Protobuf compiler plugin.
This is no longer needed, now that we pull in bazel_remote_apis as a module.
This one no longer requires us to apply a local change.
EdSchouten
force-pushed
the
eschouten/20240918-patch
branch
from
741450e to
5566036
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.