Emit additional metrics on replicate blobs and refresh blobs #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdSchouten
reviewed
Nov 18, 2024
|
|
||
| // NewMetricsBlobReplicator creates a wrapper around BlobReplicator that adds | ||
| // Prometheus metrics for monitoring replication operations. | ||
| func NewMetricsBlobReplicator(replicator BlobReplicator, clock clock.Clock) BlobReplicator { |
There was a problem hiding this comment.
Right now these metrics aren't broken down by backend/storage type. Is that intentional? If not, maybe we can simply use the backend type of the BlobAccess that they are used in conjunction with?
There was a problem hiding this comment.
added storage type, I didn't see a good way to extract backendType from blobAccess though.
EdSchouten
reviewed
Nov 19, 2024
| @@ -27,7 +27,7 @@ func NewCASBlobReplicatorCreator(grpcClientFactory grpc.ClientFactory) BlobRepli | |||
| func (brc *casBlobReplicatorCreator) NewCustomBlobReplicator(configuration *pb.BlobReplicatorConfiguration, source blobstore.BlobAccess, sink BlobAccessInfo) (replication.BlobReplicator, error) { | |||
| switch mode := configuration.Mode.(type) { | |||
| case *pb.BlobReplicatorConfiguration_Deduplicating: | |||
| base, err := NewBlobReplicatorFromConfiguration(mode.Deduplicating, source, sink, brc) | |||
| base, err := NewBlobReplicatorFromConfiguration(mode.Deduplicating, source, sink, brc, "cas") | |||
There was a problem hiding this comment.
Probably better if we move GetStorageTypeName() to implementations of BlobReplicatorCreator? Because then we can call that function from here as well.
There was a problem hiding this comment.
Good call, moved it there.
EdSchouten
reviewed
Nov 20, 2024
|
Thanks a lot, @kevinye202. You're a rockstar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds several more metrics to replicate blobs and refresh blobs, specifically batch size and blob size in bytes as well as latency, which would provide more insight in the event of slowness in findMissing and replication.