Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redirects: strip everything after a CR or a LF #4584

Merged
merged 1 commit into from
Feb 1, 2019
Merged

redirects: strip everything after a CR or a LF #4584

merged 1 commit into from
Feb 1, 2019

Conversation

tardyp
Copy link
Member

@tardyp tardyp commented Feb 1, 2019

No description provided.

@rodrigc rodrigc self-requested a review February 1, 2019 15:58
rodrigc
rodrigc approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@rodrigc rodrigc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, more of these bytes issues. Great you are fixing them!

@codecov
Copy link

codecov bot commented Feb 1, 2019 •
edited
Loading

Codecov Report

Merging #4584 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4584      +/-   ##
==========================================
+ Coverage   88.44%   88.44%   +<.01%     
==========================================
  Files         323      323              
  Lines       33650    33654       +4     
==========================================
+ Hits        29761    29765       +4     
  Misses       3889     3889
Impacted Files Coverage Δ
master/buildbot/www/resource.py 82.85% <100%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8f3bbc...e781f11. Read the comment docs.

@tardyp tardyp merged commit f0ccd5f into buildbot:master Feb 1, 2019
miamor1235
miamor1235 reviewed Mar 20, 2019
View reviewed changes
Copy link

@miamor1235 miamor1235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I please get help from buildbot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miamor1235 miamor1235 miamor1235 left review comments

@seankelly seankelly seankelly approved these changes

@rodrigc rodrigc rodrigc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tardyp @seankelly @rodrigc @miamor1235