Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golang version to 1.17.2 #1130

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Bump golang version to 1.17.2 #1130

merged 2 commits into from
Oct 18, 2021

Conversation

tempoz
Copy link
Contributor

@tempoz tempoz commented Oct 18, 2021

Version bump: Patch

tylerwilliams
tylerwilliams approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@tylerwilliams tylerwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(assuming it builds and runs and tests alright?)

tylerwilliams
tylerwilliams reviewed Oct 18, 2021
View reviewed changes
Copy link
Member

@tylerwilliams tylerwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are both require sections in go.mod intentional?

@tempoz
Copy link
Contributor Author

tempoz commented Oct 18, 2021

Yeah, go mod tidy is very insistent about them. I should probably read and see if I can determine why.

@tempoz
Copy link
Contributor Author

tempoz commented Oct 18, 2021

It looks like indirect dependencies that aren't manually added go in a separate require block from everything else: golang/go#27887

@tempoz tempoz merged commit 2c14ced into master Oct 18, 2021
@tempoz tempoz deleted the go-version-1-17-2 branch October 18, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerwilliams tylerwilliams tylerwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tempoz @tylerwilliams