Fix get group id for quota interceptor #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename record metrics interceptor to quota b/c we are also checking quota in that interceptor. Put the quota interceptor after the auth one.
bduffany
approved these changes
Jul 15, 2022
server/rpc/filters/filters.go
Outdated
| @@ -213,6 +213,7 @@ func recordRequestMetricsUnaryServerInterceptor(env environment.Env) grpc.UnaryS | |||
| } | |||
| if *enableGRPCMetricsByGroupID { | |||
| if key, err := quota.GetKey(ctx, env); err == nil { | |||
| log.Info("quota key is %q, key") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename record metrics interceptor to quota b/c we are also checking
quota in that interceptor.
Put the quota interceptor after the auth one.