Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flamefire improvements + bugfix #11

Merged
merged 22 commits into from
Dec 30, 2022
Merged

Flamefire improvements + bugfix #11

merged 22 commits into from
Dec 30, 2022

Conversation

toote
Copy link

@toote toote commented Dec 30, 2022 •
edited
Loading

This is almost the same as #7. I used it as a starting point merging it to master.

Removed changes from #7

  • Partial matching
    • NB: I believe that it may be an interesting feature, but it will probably break a lot of existing tests and it was the only breaking change. I did not remove the code, just commented it out
  • wrong exit status (had already been corrected)

Added changes on top of #7

  • Corrected all shellcheck warnings
  • Removed assumption of partial stubbing from some tests
  • Corrected handling of commands that don't make for valid variable names and added tests for it as well (closes Can not stub commands with a period #9)

You can run all tests with docker run --rm -ti -v $PWD:/code bats/bats tests

Flamefire and others added 22 commits June 20, 2019 13:18
@Flamefire
Remove debug output
36a5bc8
@Flamefire
Add more tests
d37f56f
@Flamefire
Test and fix exit status of stubbed command
81d2abf
@Flamefire
More tests
3f69977
@Flamefire
Add test for checking stdin
8eca0ff
@Flamefire
Simplify handling of stdin by running it with the original stdin as i…
8cfc2c4 
…nput
@Flamefire
Add --allow-missing to unstub
f6f08e6 
By default assert that the given command was stubbed unless that param
was given
Also avoids error message when parameter is given and program was
not stubbed
@Flamefire
Add test with star and whitespace
3f09043
@Flamefire
Disable globbing before expanding patterns
5e09ea1
@Flamefire
Allow partial matches
dfdf12e
@Flamefire
Allow incremental definition of execution plan
bdf9dcd
@Flamefire
Allow mocking of rm and others
2b744d5
@Flamefire
Remove redundant redirect
c5e1f75
@Flamefire
Accept any arguments if no ' : ' is passed or plan starts with '::'
0decdc2
@toote
Merge remote-tracking branch 'Flamefire/fixes' into flamefire_improve…
3dfc737 
…ments
@toote
Corrected indentation and shellcheck warnings
3a80b7b
@toote
Reverted how * is handled for better backwards compatibility (but rem…
5db6c3e 
…oved partial matching)
@toote
Corrected shellcheck warnings in stub.bash
b79a595
@toote
Cleanup of tests and not use incremental stubbing everywhere
dac66ef
@toote
Test that rm is actually a function
ccaa808
@toote
Updated commented out code to use debug function
c659547
@toote
Make better handling of stubs that wouldn't make valid variable names
08f2155
@toote toote requested a review from pzeballos December 30, 2022 15:11
pzeballos
pzeballos approved these changes Dec 30, 2022
View reviewed changes
Copy link

@pzeballos pzeballos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻👏🏻👏🏻👏🏻

@pzeballos pzeballos merged commit f952747 into master Dec 30, 2022
@toote toote deleted the flamefire_improvements branch April 10, 2023 22:42
@toote toote mentioned this pull request Jun 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzeballos pzeballos pzeballos approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not stub commands with a period
3 participants
@toote @pzeballos @Flamefire