Contribution docs #36
Conversation
Added contribution docs
Added docker-compose.yml
stephanieatte
requested review from
jeremybumsted
and removed request for
a team
There was a problem hiding this comment.
Testing this locally, make test from the contribution docs and docker compose run --rm plugin_test seem to fail with bats issues.
bats_load_safe: Could not find '/usr/local/lib/bats/load.bash'[.bash]@stephanieatte Not sure if anything needs to be updated there or if it's a me issue? Have you run the tests locally to make sure everything works?
docker-compose.yml
Outdated
| --- | ||
| version: '3' | ||
| services: | ||
| plugin_test: | ||
| build: | ||
| context: . | ||
| dockerfile: ./tests/Dockerfile | ||
| plugin_lint: | ||
| image: buildkite/plugin-linter:latest | ||
| command: ['--id', 'monebag/monorepo-diff'] | ||
| volumes: | ||
| - ".:/plugin" |
There was a problem hiding this comment.
This was removed because it's unused and it's referencing monebag, so it won't work
|
Will check on the contribution docs to make sure it works just like it should |
|
or
The lint test fails on the build checking this out right now |
|
@jeremybumsted @pzeballos i have made the changes please can you confirm that it works on your end |
Replaced deprecated flags
There was a problem hiding this comment.
@stephanieatte awesome stuff
I think we're still needing to change some things in the actual CONTRIBUTING doc as we reference GitHub actions when it's now all done via the plugin pipeline, and the entire testing section will probably need an update.
This PR adds some key sections and documents that have been omitted. It allows users to run tests with docker and make test without docker compose