Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUP-1952: Enable using Environment Variables to configure Wiz API Secret #3

Merged
merged 9 commits into from
Mar 27, 2024

Conversation

tomowatt
Copy link

To allow use other other Secrets Managers, allowed choosing with Environment Variable should be used which contains the the Wiz API Secret. Defaults to using WIZ_API_SECRET but the api-secret-env plugin config allows switching to any defined Environment Variable.

Copy link

@jeremybumsted jeremybumsted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small suggestions, but otherwise looks good :)

README.md Outdated Show resolved Hide resolved
### `api-secret-env` (Optional, string)

The environment variable that the Wiz API Secret is stored in. Defaults to using `WIZ_API_SECRET`.

### `scan-type` (Required, string) : 'docker | iac'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a default scan type?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will also mention should update plugin.yml with the required configuration but that should be a separate PR
https://json-schema.org/draft/2020-12/json-schema-validation#name-required

Copy link

@jeremybumsted jeremybumsted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

@tomowatt tomowatt merged commit 0a33b94 into main Mar 27, 2024
1 check passed
@tomowatt tomowatt deleted the SUP-1952 branch March 28, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants