Fix jobs are not acquired in when in a queue in a cluster #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triarius
force-pushed
the
pdp-775-acquire-is-failing-for-clusters
branch
from
0ed27c7
to
41106e9
Compare
tessereth
approved these changes
Mar 29, 2023
|
@tessereth This agent acquired and ran a job in a cluster on Kubernetes and the controller was built from the commit that this branch points to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the the controller was only pulling jobs from the
kubernetesqueue, it was starting the agents in thedefaultqueue because that's the default, and it did not specify one. With a cluster token, jobs can no longer be acquired across queues, so the API would give a 404 when the agent tried to acquire the job.So in this PR, we add the queue to the
BUILDKITE_AGENT_TAGSenv variable that will be passed into theagent startcontainer, which will then acquire the job from the correct queue.