Some cleanup related to code generations #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It allows dependabot to bump the dependencies for tools, which is better than putting the versions in a bash script and never bumping them.
triarius
changed the title
DrJosh9000
approved these changes
Apr 20, 2023
.buildkite/pipeline.yml
Outdated
| podSpec: | ||
| containers: | ||
| - name: docker | ||
| image: golang:1.20.2-alpine |
There was a problem hiding this comment.
I think the latest is 1.20.3
There was a problem hiding this comment.
I made a pragmatic decision to drop the versioning of these. I would expect some bot to keep them up to date, but I don't think Dependabot supports this. The commit message comment has more justification on why an unversioned container is ok.
It's not necessary to pin the version as this is a job that does not produce artefacts that we ship, and go's compatibility promise should mean that any future version of go should be able to compile this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main addition is to generate the GraphQL client when
go genereate ./...is run, and a step in CI to ensure generated code has been checked in.Other than that there is some standardisation of how code is generated, conversion of tests package name to be suffixed with
_testand some cosmetic changes to the pipeline.