Fail jobs without starting pods #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
podless-failure
branch
9 times, most recently
from
faa59e7 to
b8e175b
Compare
DrJosh9000
changed the title
DrJosh9000
force-pushed
the
podless-failure
branch
from
b8e175b to
9049bff
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So a job is nonsense, a pod can't be constructed, or Kubernetes won't accept it. Currently, we build a whole 'nother pod containing an agent, a command container, an init container, etc using the default agent image, and tell it to...
which smacks of cracking a walnut with the Mesta 50000.
This PR changes it so that the scheduler uses the new agent functionality introduced in buildkite/agent#2915 -
core.Controllerandcore.JobController- to acquire and fail the job directly within the agent-stack-k8s controller.Fixes #273