Reduce MaxInFlight integration test flakes #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
fix-maxinflight-tests
branch
2 times, most recently
from
e8b4d13
to
94225f0
Compare
DrJosh9000
force-pushed
the
fix-maxinflight-tests
branch
from
94225f0
to
dc0c111
Compare
DrJosh9000
force-pushed
the
fix-maxinflight-tests
branch
from
dc0c111
to
f4e5853
Compare
DrJosh9000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MaxInFlightUnlimited integration test is flaky. This PR doesn't make it completely unflaky (I have ideas but it adds significant complication), but should reduce the chances of flakiness. While here, I tidied up some nits I had with the style, and made MaxInFlightLimited consistent with those changes.