Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Buildkite endpoints configurable #385

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Make Buildkite endpoints configurable #385

merged 1 commit into from
Oct 1, 2024

Conversation

DrJosh9000
Copy link
Contributor

@DrJosh9000 DrJosh9000 commented Sep 30, 2024 •
edited
Loading

This could be useful when running against a dev instance of Buildkite itself.

@DrJosh9000 DrJosh9000 marked this pull request as ready for review September 30, 2024 07:13
@DrJosh9000 DrJosh9000 changed the title Make GraphQL endpoint configurable Make Buildkite endpoints configurable Sep 30, 2024
@SorchaAbel
Copy link
Contributor

@DrJosh9000 this is amazing! I can't believe how fast you did this

SorchaAbel
SorchaAbel approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@SorchaAbel SorchaAbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not the best person to approve but selfishly I want this and it all LGTM

@DrJosh9000
Copy link
Contributor Author

I tested it and it works. The main wrinkle is that the graphql-endpoint and agent-endpoint hosts (agent.buildkite.localhost and graphql.buildkite.localhost in the example) can't map to 127.0.0.1 in /etc/hosts. That would cause the controller and any pods it creates to connect to itself, not a dev instance. Running dev Buildkite locally, I edited /etc/hosts to use the LAN address of the machine instead of a loopback address.

@DrJosh9000 DrJosh9000 merged commit 3c42922 into main Oct 1, 2024
1 check passed
@DrJosh9000 DrJosh9000 deleted the add-graphql-endpoint-config branch October 1, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SorchaAbel SorchaAbel SorchaAbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrJosh9000 @SorchaAbel