Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidyups in .buildkite #390

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Tidyups in .buildkite #390

merged 2 commits into from
Oct 11, 2024

Conversation

DrJosh9000
Copy link
Contributor

@DrJosh9000 DrJosh9000 commented Oct 2, 2024

What

  • Shell tidyups: handlebars, quotes
  • Update Go to 1.23
  • Refactor env, volumes, and volume mounts using YAML anchors
  • Give release step access to the Go caches

Why

The release step is slow, maybe this will help?

@DrJosh9000 DrJosh9000 force-pushed the steps-shell-tidyups branch 10 times, most recently from c63d155 to f1a25b0 Compare October 9, 2024 04:26
@DrJosh9000 DrJosh9000 force-pushed the steps-shell-tidyups branch 2 times, most recently from ca6b03f to 771b681 Compare October 9, 2024 06:23
@DrJosh9000 DrJosh9000 requested a review from a team October 10, 2024 05:03
@DrJosh9000 DrJosh9000 changed the title Shell tidyups in .buildkite/steps Tidyups in .buildkite Oct 10, 2024
Copy link
Contributor

@CerealBoy CerealBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DrJosh9000 DrJosh9000 merged commit 46dff5c into main Oct 11, 2024
1 check passed
@DrJosh9000 DrJosh9000 deleted the steps-shell-tidyups branch October 11, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants