Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix s/"bool"/"boolean"/ in JSON Schema #394

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix s/"bool"/"boolean"/ in JSON Schema #394

merged 1 commit into from
Oct 8, 2024

Conversation

DrJosh9000
Copy link
Contributor

@DrJosh9000 DrJosh9000 commented Oct 8, 2024 •
edited
Loading

Oops. "boolean" is valid, "bool" is not.

wolfeidau
wolfeidau approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@wolfeidau wolfeidau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a checker for this file?

@DrJosh9000 DrJosh9000 merged commit a56a145 into main Oct 8, 2024
1 check passed
@DrJosh9000 DrJosh9000 deleted the fix-json-schema branch October 8, 2024 05:42
@DrJosh9000
Copy link
Contributor Author

do we need a checker for this file?

Yeah that would probably save some time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfeidau wolfeidau wolfeidau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrJosh9000 @wolfeidau