Fix VolumeSource in JSON Schema #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
fix-volumesource-json-schema
branch
from
de970b4
to
f12da50
Compare
DrJosh9000
force-pushed
the
fix-volumesource-json-schema
branch
from
f12da50
to
1b967c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
VolumeSourceis just an artefact of the Go library implementation - the JSON Schema has no concept ofVolumeSource, onlyVolume. (And "name" is required, per the schema.)I suppose the user should be able to change the volume name if they want, anyway.
I tested it and it works: