Fix leftover pods from test #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
fix-leftover-pods-from-test
branch
3 times, most recently
from
3a975f3
to
7abfab1
Compare
...from TestImagePullBackOffFailed. The role had no rights to create evictions, so the dead pods weren't being automatically evicted.
DrJosh9000
force-pushed
the
fix-leftover-pods-from-test
branch
from
7abfab1
to
ecd9bee
Compare
CerealBoy
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestImagePullBackOffWatcherseems to leave a pending pod lying around. The role didn't have the permissions to create evictions. That rule was added to the template, but not to our own rbac.yaml.