Fix parsing configs with dots in mapping keys #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
fix-values-yaml-parsing
branch
2 times, most recently
from
d004f97
to
81248c7
Compare
|
@DrJosh9000 did you consider |
|
I suppose |
DrJosh9000
force-pushed
the
fix-values-yaml-parsing
branch
from
81248c7
to
8fc8a3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change viper's key delimiter to something other than
..Why
Viper unmarshals keys with
.s as a series of nested maps, instead of as a single string key. Which is frustrating when the Kubernetes convention is to use domain names within keys.