Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Create -> Handle, + more logs and comments to aid debugging #423

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Rename Create -> Handle, + more logs and comments to aid debugging #423

merged 1 commit into from
Nov 18, 2024

Conversation

DrJosh9000
Copy link
Contributor

Rename the Create method of JobHandler to Handle, to make it clear that not every JobHandler implementation actually creates pods.
Add extra comments and some more debug log calls to make the flow of jobs easier to understand.

SorchaAbel
SorchaAbel approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@SorchaAbel SorchaAbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments are so good. And great idea to rename from create to handle.

@DrJosh9000 DrJosh9000 merged commit b658a93 into main Nov 18, 2024
1 check passed
@DrJosh9000 DrJosh9000 deleted the extra-logs-and-comments branch November 18, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SorchaAbel SorchaAbel SorchaAbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrJosh9000 @SorchaAbel