Executable hooks on windows probably have to be .exe, ay?

buildkite · May 18, 2023 · 2f7e950 · 2f7e950
1 parent 5456bcb
commit 2f7e950
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/bootstrap/integration/hooks_integration_test.go b/bootstrap/integration/hooks_integration_test.go
@@ -546,6 +546,11 @@ func TestPolyglotBinaryHooksCanBeRun(t *testing.T) {
 
 	fmt.Println("Building test-binary-hook")
 	hookPath := filepath.Join(tester.HooksDir, "environment")
+
+	if runtime.GOOS == "windows" {
+		hookPath += ".exe"
+	}
+
 	output, err := exec.Command("go", "build", "-o", hookPath, "./test-binary-hook").CombinedOutput()
 	if err != nil {
 		t.Fatalf("Failed to build test-binary-hook: %v, output: %s", err, string(output))

diff --git a/hook/hook.go b/hook/hook.go
@@ -18,7 +18,7 @@ import (
 func Find(hookDir string, name string) (string, error) {
 	if runtime.GOOS == "windows" {
 		// check for windows types first
-		if p, err := shell.LookPath(name, hookDir, ".BAT;.CMD;.PS1"); err == nil {
+		if p, err := shell.LookPath(name, hookDir, ".BAT;.CMD;.PS1;.EXE"); err == nil {
 			return p, nil
 		}
 	}