fix: 🪶 experiment normalised-upload-paths was left out of the list of available experiments
#2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of available experiments
moskyb
approved these changes
May 10, 2023
There was a problem hiding this comment.
ah, i can't believe i missed this! thanks so much @MatthewDolan, nice catch
| @@ -1308,7 +1308,7 @@ func (b *Bootstrap) defaultCheckoutPhase(ctx context.Context) error { | |||
| var mirrorDir string | |||
|
|
|||
| // If we can, get a mirror of the git repository to use for reference later | |||
| if experiments.IsEnabled(`git-mirrors`) && b.Config.GitMirrorsPath != "" && b.Config.Repository != "" { | |||
There was a problem hiding this comment.
aha, i was foolish in searching only for "git-mirrors". nice catch!
There was a problem hiding this comment.
Sorry, bad habit of mine is using `` for const-ish strings.
you would hypothesize correctly 😅 |
…not match variable value
auto-merge was automatically disabled
May 10, 2023 03:56
Head branch was pushed to by a user without write access
|
Sorry. I fixed on last typo I noticed in the variable name (I had used the American spelling) so it disabled auto-merge. Thanks for the review! |
|
ah thank you! |
|
Any chance of getting a release of this out ASAP @moskyb? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing this warning in our Buildkite jobs:
It looks like the experiment is present and does do something.
I would hypothesize that this is just an accidental oversight to leave this out of the list.