Reorganise step types among files #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moskyb
approved these changes
Aug 2, 2023
I thought about continuing "(type)_step.go", but I think that grouping them under a common prefix makes them a little easier to see in file listings. I also separated input, wait, and scalar (which includes both input and wait), but I'm OK to be pushed back on that.
DrJosh9000
force-pushed
the
reorg-step-types
branch
from
2e1e388
to
301026c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought about continuing "(type)_step.go", but I think that grouping them under a common prefix makes them a little easier to see in file listings.
I also separated input, wait, and scalar (which includes both input and wait), but I'm OK to be pushed back on that.