fix for layout issues with log messages #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfeidau
force-pushed
the
fix_logger_fmt_functions
branch
from
1838425
to
e75026f
Compare
jradtilbrook
approved these changes
Aug 15, 2024
wolfeidau
force-pushed
the
fix_logger_fmt_functions
branch
from
e75026f
to
8cd6fda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the group expansion characters are printed
^^^ +++whilst also using ansi colours, our log rendering in the UI does not expand the group, so the message is hidden.Context
Changes in #2805 a while back adjusted the structure of the messages slightly when using ansi color, this resulted in some formatting issues.
With @tessereth expert guidance we found the issue and added a test to validate it.
Changes
Just moved the
^^^ +++sequence out of the ansi formatting.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)