Updated to support only ECC_NIST_P256 keyspec for initial release #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfeidau
force-pushed
the
fix_update_algos
branch
from
42fc72e
to
5b2c8d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reduces the support for key types to just
ECC_NIST_P256for the initial release.Context
The reason I removed the other key types are:
ECC_NIST_P256is the only ECDSA KMS key type tested forcrypto.Signingwith KMS in our JWS library, I will need to raise this upstream to figure out why.So given the
ECC_NIST_P256is widely used I think it is fine as a starting point for KMS signing support.