Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sha256 checksum output to the formatting options #2974

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

patrobinson
Copy link
Contributor

@patrobinson patrobinson commented Sep 6, 2024

Description

When running artifact shasum you can optionally print the SHA256 checksum for a single artifact.
But if you're trying to list multiple artifacts using the search subcommand, we only support printing the SHA1 checksum

Changes

Add new formatting option, %T, for SHA256. I chose t because it's the next letter in the alphabet and both %s and %S are taken. Open to suggestions!

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

image

Copy link
Contributor

@wolfeidau wolfeidau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 looks good

@patrobinson patrobinson merged commit dfc5a44 into main Sep 6, 2024
1 check passed
@patrobinson patrobinson deleted the add-sha256sum-format-option branch September 6, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants