Fix for region discovery issue with aws sdkv2 when running in ec2 #2977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfeidau
force-pushed
the
fix_aws_sdkv2_region_discovery
branch
from
4bf82d5
to
8cb13c0
Compare
wolfeidau
force-pushed
the
fix_aws_sdkv2_region_discovery
branch
from
8cb13c0
to
90b7d65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new KMS signing support uses aws sdkv2, this automatically discovers region from environment or local configuration files, however it doesn't automatically use imds. This code replicates the v1 local configuration preference with fall back to imds service.
Context
Changes
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)