Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain verification-failure-behavior in more detail #2984

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

DrJosh9000
Copy link
Contributor

Description

Fix the usage string to list more cases where "warn" mode continues with the job.

Context

Got side-tracked and ended up looking at what the behaviour actually was.

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

Copy link
Contributor

@wolfeidau wolfeidau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pickup 👍🏻 🚀

@DrJosh9000 DrJosh9000 merged commit f2df9f8 into main Sep 10, 2024
1 check passed
@DrJosh9000 DrJosh9000 deleted the verification-failure-behavior-usage branch September 10, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants