Consolidate artifact functionality in internal package #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
artifact-tidy
branch
2 times, most recently
from
b724c8f to
3ec5580
Compare
DrJosh9000
force-pushed
the
artifact-tidy
branch
2 times, most recently
from
cfaa006 to
ae9e153
Compare
DrJosh9000
force-pushed
the
artifact-tidy
branch
from
ae9e153 to
550d91c
Compare
|
@DrJosh9000 great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2204 lives!
Artifact-related library functionality isn't intended to be imported and used outside the agent. This moves all the artifact stuff out of
agentinto its own internal package.Since there are some common AWS things needed from the new artifact package, these are also factored into their own internal package.
Context
Preparing to work on more artifact things, maybe.
Changes
internal/artifactinternal/awslibArtifact)os.Chdir, making the tests parallelizable.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)