-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily pin kubectl version #2997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it probably makes sense to pin this anyway, rather than blindly using whatever the latest k8s is... though i suppose this way, we run the risk of forgetting to update k8s.
either way, ✅ in favour of fixing main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the risk of nerd-sniping you, is there a way we could make dependabot bump this?
RUN <<EOF | ||
set -eu | ||
|
||
VERSION=$(wget -qO- https://dl.k8s.io/release/stable.txt) | ||
wget -qO kubectl \ | ||
"https://storage.googleapis.com/kubernetes-release/release/$VERSION/bin/linux/$TARGETARCH/kubectl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"https://storage.googleapis.com/kubernetes-release/release/$VERSION/bin/linux/$TARGETARCH/kubectl" | |
"https://storage.googleapis.com/kubernetes-release/release/${K8_VERSION}/bin/linux/$TARGETARCH/kubectl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrobinson @DrJosh9000 can we just pull this out of a container so we get pinning and a supported source?
wget binary feels not ideal.
The latest release hasn't been uploaded to the GCP bucket yet, which is causing our build to fail
933a71c
to
b0fc590
Compare
@DrJosh9000 to do that I think we'd want to switch to using the container
|
Description
main build is failing
The latest k8s release hasn't been uploaded to the GCP bucket yet, which is causing our build to fail
Changes
Pin the k8s version for now
Testing
go test ./...
). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...
)