Prefer $HOME on all platforms #3000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrobinson
approved these changes
Sep 17, 2024
internal/osutil/homedir.go
Outdated
| // over other options (such as USERPROFILE on Windows). | ||
| func UserHomeDir() (string, error) { | ||
| h := os.Getenv("HOME") | ||
| if h != "" { |
There was a problem hiding this comment.
Is there any preference of this style over?:
if h := os.Getenv("HOME"); h != "" {There was a problem hiding this comment.
No, in fact I think we should prefer it that way. Just hammered out the code quickly.
moskyb
approved these changes
Sep 17, 2024
DrJosh9000
force-pushed
the
fix-homedir
branch
2 times, most recently
from
a84465e
to
d8610af
Compare
DrJosh9000
force-pushed
the
fix-homedir
branch
from
d8610af
to
6a6dfa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2990 is good, but is likely to be a breaking change on Windows particularly. For instance the Elastic CI Stack runs the agent with
HOME=C:\buildkite-agent.Rather than revert #2990, in the spirit of Go Proverbs I propose we do a little copying instead of a little dependency.
Changes
osutil.UserHomeDir, which wrapsos.UserHomeDirand prefers$HOMEwhen available.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)