Add support for oidc aws session tags #3015
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Teach the agent how to request OIDC tokens including aws session tags:
Claims are then added to the returned token as aws session tags using their prescribed format:
https://docs.aws.amazon.com/IAM/latest/UserGuide/id_session-tags.html#id_session-tags_adding-assume-role-idp
which can then be used to grant permission to aws resources using attribute based access control (ABAC):
https://docs.aws.amazon.com/IAM/latest/UserGuide/tutorial_attribute-based-access-control.html
This is a finer grained control than the subject condition based option currently available:
https://buildkite.com/docs/pipelines/security/oidc/aws#step-2-create-a-new-or-update-an-existing-iam-role-to-use-with-your-pipelines
The Buildkite Agent API already supports this parameter.
Changes
Mostly copy/pasta of how
--claim
works. I also added an api test forclaims
alongsideaws_session_tags
.Testing
go test ./...
). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...
)That will do the job.