Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all string slice args have whitespace cleaned off of each element #3021

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Ensure all string slice args have whitespace cleaned off of each element #3021

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee70db6
Strip whitespace on optional claim names
moskyb Oct 2, 2024
fe814e2
Ensure all string slice args get whitespace cleaned
moskyb Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions clicommand/oidc_request_token.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"fmt"
"net/http"
"strings"
"time"

"github.com/buildkite/agent/v3/api"
Expand Down Expand Up @@ -110,6 +111,10 @@ var OIDCRequestTokenCommand = cli.Command{
return fmt.Errorf("lifetime %d must be a non-negative integer.", cfg.Lifetime)
}

for i, claim := range cfg.Claims {
cfg.Claims[i] = strings.TrimSpace(claim)
}

// Create the API client
client := api.NewClient(l, loadAPIClientConfig(cfg, "AgentAccessToken"))

Expand Down