Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install.sh tidyups #3032

Merged
merged 1 commit into from
Oct 11, 2024
Merged

install.sh tidyups #3032

merged 1 commit into from
Oct 11, 2024

Conversation

DrJosh9000
Copy link
Contributor

@DrJosh9000 DrJosh9000 commented Oct 9, 2024 •
edited
Loading

Description

install.sh is in need of some love. I borrowed some ideas from https://getmic.ro

Context

https://coda.io/d/Escalations-Feedback_dHnUHNps1YO/Pipelines-In-Progress-Board_suIFKYEb#Escalations-Pipelines_tuQbCBf6/r732&view=modal

Changes

  • More quotes and handlebars
  • Refactor picking the HTTP client program (wget/curl)
  • Use mktemp -d, and a cleanup trap
  • Heredoc
  • Use the new-ish SHA256SUMS file to checksum the file, with an escape hatch

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)
  • Works on macOS
  • Works on Ubuntu

@DrJosh9000 DrJosh9000 force-pushed the update-install-sh branch 2 times, most recently from a80ca86 to 129dea0 Compare October 10, 2024 04:32
@DrJosh9000 DrJosh9000 marked this pull request as ready for review October 10, 2024 04:33
@DrJosh9000 DrJosh9000 force-pushed the update-install-sh branch 2 times, most recently from 10fe604 to 8a8380d Compare October 10, 2024 05:08
swaller-bk
swaller-bk approved these changes Oct 10, 2024
View reviewed changes
Copy link

@swaller-bk swaller-bk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on darwin amd64, I was able to use the releases dir to trigger the checksum check, nice work!

@DrJosh9000 DrJosh9000 merged commit 07904ac into main Oct 11, 2024
1 check passed
@DrJosh9000 DrJosh9000 deleted the update-install-sh branch October 11, 2024 00:41
This was referenced Oct 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaller-bk swaller-bk swaller-bk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrJosh9000 @swaller-bk