Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tini-static to alpine images #3054

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

DrJosh9000
Copy link
Contributor

Description

Install both tini and tini-static in alpine and alpine-k8s.

Context

This is the easiest way to make tini-static available to agent-stack-k8s, which will be needed for defunct-process-reaping within arbitrary container images. agent-stack-k8s by default uses the agent alpine image, not alpine-k8s, but I think they should be somewhat consistent.

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

Copy link
Contributor

@wolfeidau wolfeidau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@DrJosh9000 DrJosh9000 merged commit 2e40f51 into main Oct 28, 2024
1 check passed
@DrJosh9000 DrJosh9000 deleted the add-tini-static-to-alpines branch October 28, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants