Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update to the 'redactor' CLI command examples. #3060

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

gilesgas
Copy link
Contributor

In the 'redactor' CLI command examples, this PR removes the equal signs from the --format options, to match options table in docs, where the option is specified as --format value.

It's better to keep examples and options tables consistent, to avoid customer/reader confusion.

Nevertheless, using an equal sign in this context, or not, should make no functional difference to the way this option is used.

…e the presence of this sign (or lack therefore) making no functional difference.
Copy link
Contributor

@DrJosh9000 DrJosh9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@gilesgas gilesgas marked this pull request as draft October 30, 2024 03:12
@gilesgas
Copy link
Contributor Author

gilesgas commented Oct 30, 2024

Thanks @DrJosh9000 ! Espescially for the super-fast approval there!

Just want to add a couple more tweaks to at least one of the related option descriptions, now that I've read them in a tad more detail ;-)

@gilesgas gilesgas marked this pull request as ready for review October 30, 2024 03:21
@gilesgas gilesgas merged commit a210a7d into main Oct 30, 2024
1 check passed
@gilesgas gilesgas deleted the redactor-cli-minor-wording-tweaks branch October 30, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants