Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote polyglot-hooks experiment to default #3063

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Promote polyglot-hooks experiment to default #3063

merged 1 commit into from
Oct 31, 2024

Conversation

DrJosh9000
Copy link
Contributor

Description

Promote polyglot-hooks 🎉

Context

Polyglot hooks was added as an experiment in May 2023. It's high time this was just made default.

Changes

  • Move the experiment into "promoted"
  • Remove the conditional
  • Remove the experiment setup in tests

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

wolfeidau
wolfeidau approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@wolfeidau wolfeidau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 really want to try this 🚀

@DrJosh9000 DrJosh9000 enabled auto-merge October 31, 2024 05:10
@DrJosh9000 DrJosh9000 merged commit cc4a028 into main Oct 31, 2024
1 check passed
@DrJosh9000 DrJosh9000 deleted the promote-polyglot-hooks branch October 31, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfeidau wolfeidau wolfeidau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrJosh9000 @wolfeidau