Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support installing specific versions via script #3069

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

jordandcarter
Copy link
Contributor

@jordandcarter jordandcarter commented Nov 6, 2024

Description

Add support for specifying agent version when installing via install.sh or install.ps1. Pulled upstream from https://github.com/elastic/buildkite-agent thanks to @esenmarti!

To set the agent version use the following before running the install script.

  • Windows
    • $env:buildkiteAgentVersion = "3.84.0"
  • Linux
    • BUILDKITE_AGENT_VERSION = "3.84.0"

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

@jordandcarter jordandcarter requested a review from a team November 6, 2024 04:24
Copy link
Contributor

@wolfeidau wolfeidau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻 from me.

Copy link
Contributor

@DrJosh9000 DrJosh9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some nitpicks on the Bash side. The Powershell side LGTM assuming it runs, but I'm less knowledgeable.

install.sh Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
Co-authored-by: Josh Deprez <jd@buildkite.com>
@jordandcarter jordandcarter changed the title Install support version pinning Support installing specific versions via script Nov 6, 2024
@jordandcarter jordandcarter merged commit 8938472 into main Nov 6, 2024
1 check passed
@jordandcarter jordandcarter deleted the install-support-version-pinning branch November 6, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants