Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer panic in k8s mode #3074

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix nil pointer panic in k8s mode #3074

merged 1 commit into from
Nov 8, 2024

Conversation

DrJosh9000
Copy link
Contributor

Description

kubernetesSetup used e.shell to log before e.shell was created. Oops.

Context

https://coda.io/d/Escalations-Feedback_dHnUHNps1YO/Pipelines-Escalations_suQ4B7FT#Pipelines-Escalations-Board_tu66S__K/r822&view=center

Changes

  • Don't log anything in kubernetesSetup
  • Move the temporary logger up from setupRedactors and use that.

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

@DrJosh9000 DrJosh9000 enabled auto-merge November 8, 2024 22:36
catkins
catkins approved these changes Nov 8, 2024
View reviewed changes
Copy link

@catkins catkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DrJosh9000

@DrJosh9000 DrJosh9000 merged commit 232e39f into main Nov 8, 2024
1 check passed
@DrJosh9000 DrJosh9000 deleted the k8s-fix-nil-pointer branch November 8, 2024 23:50
@DrJosh9000 DrJosh9000 mentioned this pull request Nov 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catkins catkins catkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrJosh9000 @catkins