Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another nil pointer panic in k8s mode #3075

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

DrJosh9000
Copy link
Contributor

Description

kubernetesSetup tries to mutate e.shell.Env, but e.shell isn't set yet. Oops.

Context

https://coda.io/d/Escalations-Feedback_dHnUHNps1YO/Pipelines-In-Progress-Board_suIFKYEb#Escalations-Pipelines_tuQbCBf6/r822&view=modal

Changes

  • Move the environ up
  • Pass it into kubernetesSetup in order to change it.

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

@DrJosh9000 DrJosh9000 merged commit 5d3194c into main Nov 9, 2024
1 check passed
@DrJosh9000 DrJosh9000 deleted the k8s-fix-nil-pointer-2 branch November 9, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants