Handle older version of remote ref error message #3082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have code to handle the case where we can't fetch a short remote ref and fall back to fetching all tags. However the case of this error changed in git v2.21.0 (2019) and we only caught the new lowercase version. Handle the old title case version to support customers running old versions of git.
steveh
deleted the
ps-179-handle-different-case-of-invalid-remote-ref-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have code to handle the case where we can't fetch a short remote ref and fall back to fetching all tags. However the case of this error changed in git v2.21.0 (2019) and we only caught the new lowercase version. Handle the old title case version to support customers running old versions of git.
Context
Linear PS-179
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)