Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to agent-base images #3091

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Switch to agent-base images #3091

merged 1 commit into from
Nov 18, 2024

Conversation

DrJosh9000
Copy link
Contributor

@DrJosh9000 DrJosh9000 commented Nov 14, 2024

Description

Speed up agent builds. A large amount of the pipeline is spent in apt-get install ... for the Ubuntu images. I've split that part out into https://github.com/buildkite/agent-base-images which push to Public ECR - so we can do a scheduled build of that, and use Dependabot to update the pins here.

Changes

  • Point to public.ecr.aws/buildkite/agent-base
  • Remove the parts that agent-base-images now builds into the new base images.

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

@DrJosh9000 DrJosh9000 marked this pull request as ready for review November 14, 2024 00:23
@DrJosh9000 DrJosh9000 force-pushed the use-agent-base-images branch 6 times, most recently from 7388de8 to c853db0 Compare November 14, 2024 03:35
@DrJosh9000 DrJosh9000 enabled auto-merge November 14, 2024 04:07
@DrJosh9000 DrJosh9000 force-pushed the use-agent-base-images branch from c853db0 to aa8c155 Compare November 14, 2024 04:57
@DrJosh9000 DrJosh9000 requested a review from a team November 14, 2024 05:31
@DrJosh9000 DrJosh9000 force-pushed the use-agent-base-images branch from aa8c155 to 96223f7 Compare November 17, 2024 23:50
Copy link
Contributor

@moskyb moskyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@DrJosh9000 DrJosh9000 merged commit 896685c into main Nov 18, 2024
1 check passed
@DrJosh9000 DrJosh9000 deleted the use-agent-base-images branch November 18, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants