Soft fail upload of packages docker images #3093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…build custom domains, if any errors occur we shouldn't block agent deploys. When agents are served by buildkite packages soft_fail should be removed
isaacsu
approved these changes
Nov 15, 2024
tommeier
deleted the
pkg-7830-change-agent-pipeline-to-soft-fail-on-packages-uploads
branch
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Packages upload of docker images isn't on the critical path until we build custom domains, if any errors occur we shouldn't block agent deploys. When agents are served by buildkite packages soft_fail should be removed. Other steps are already soft fail but this needs an update on the docker to packages specific variation on the matrix.
When this build failed https://buildkite.com/buildkite/agent-release-stable/builds/149#01930ac6-f742-4aca-a10e-74aeb7456373 - it was on the upload to docker step for packages and actively blocked a critical release for Shopify.
Context
https://linear.app/buildkite/issue/PKG-7830/change-agent-pipeline-to-soft-fail-on-packages-uploads
Changes
Changes docker deploy step to make packages.buildkite.com step to be
soft_failPretty sure this is the right way to do it, but I've not done anything with matrix step before:
https://buildkite.com/docs/pipelines/build-matrix#adding-combinations-to-the-build-matrix